[DIT-12000] Add iosLocales Configuration Support #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrish17
requested review from
JWhite30515
and removed request for
joustrich
bparrish17
requested review from
laurakoye
and removed request for
JWhite30515
laurakoye
reviewed
Dec 22, 2025
laurakoye
left a comment
laurakoye
left a comment
There was a problem hiding this comment.
I didn't encounter any issues testing. I know you wanted to get another review, so I'll just leave my comments.
laurakoye
requested changes
Dec 22, 2025
laurakoye
left a comment
laurakoye
left a comment
There was a problem hiding this comment.
Found what I think is an issue:
https://www.loom.com/share/d619af17b17d4f7f95991f894ed2600c
If I have a variant applied to a text item the generated string and string dics are showing the base text. This is true even if the variant has plurals on it.
…o iosLocale directories
laurakoye
approved these changes
Jan 7, 2026
bparrish17
added a commit
that referenced
this pull request
Jan 8, 2026
* [DIT-11970] iOS Strings Format Support (#129) * Add scaffolding for ios-strings support, notably IOSStringsFormatter class, and IOSStringsOutput file * Add /v2/variants endpoint. Update IOSStringsFormatter to pull down variants and projects as expected. Moved shared BaseFormatter class methods out of JSON and IOSStringsFormatters * Minor inline doc updates * Add pull command E2E tests for outputted ios-strings files. Added component mapping to iosStringsFormatter * Add unit tests to IOSSTringsFormatter class * Update variant fetching to be shared across textItems and components. Unit tests additions to IOSStringsFormatter class * Update http request tests to handle default error * Minor: test fix * Minor: cleanup and .gitignore of local items * [DIT-11792][DIT-11791][DIT-11960] IOS Strings Dict, Android, ICU format additions (#130) * Add ios-stringsdict support to BaseFormatter * Refactor IOSStringsFileFormatter into BaseExportFormatter to be shared amongst all export formats. Updated IOSStringsDict to use that class * Add android export format * Add BaseExportFormatter class tests. Updated IOSStringsFormatter tests to no longer include baseExport method tests. Updated all formats to test for correct output file creation * Update base generateQueryParams to take in filters as sole param * Add i18n test cases * Add ios-stringsdict and Android XML formatting tests to pull * Add ICU format. Update HTTP Response types to allow for JSON. Added generics to BaseFormatter to allow for parameter-ized response types * Updated ExportComponentsResponse and TextItemsResponse Zod schema * Made BaseExportFormatter abstract class * Minor: clean * Test fix and HTTP wrapper cleanup * Minor: clean * Add promise.all to fetchTextItemsMap and fetchComponentsMap for performance * [DIT-12000] Add iosLocales Configuration Support (#132) * Add iosLocale to config and file generation * Add new fetch request for swift file from API * Add Swift file generation logic to baseexport class * clean for PR * Add test cases to ios methods on baseExport class * Minor: clean * minor: remove unused type * minor: remove test script * update pull params for export endpoints * Update all instances of 'icu' to be 'json_icu' * Address initial PR comments * Add swift file generation to root of pull command. Address some cleanup review comments * Fix pull command tests for iosLocales * Move generateSwiftFile tests to util file * Minor clean * Remove console log and fix test data * Add test case for empty iosLocalese array * Minor name clarification * Fix format default case, missing promise.all, and typing issue * Added ios-specific getLocalesPath method to those classes, along with tests * Fix issue where ___<variant_id> suffixed files were getting written to iosLocale directories * Split up textItems and components HTTP calls for export vs default * Replaced all instances of 'base' with BASE_VARIANT_ID const in lib/src directory. Removed now-unnecessary type params from Formatter classes * Fix text item text status duplicates from merge. Bump version minor * Fix status filter merge issue * Fix to base variant not getting included in variants (id: all). minor cleanup of statuses qp * Add fetchVariants tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
iosLocalesto project YAML configiosLocalesprovided in conjunction withios-stringsorios-stringsdictoutputs, will write mapped variants to a<locale>.projdirectory in the project YAML'soutDiriosLocales, will write tooutput'soutDiras usualContext
DIT-12000: [CLI] Add iOSLocales Configuration
Test Plan
Config setup: Make sure to have
iosLocalesat the root of your project directory. Ideally you have a few variants in your local setup. If so, have at least a couple of them mapped to a locale, e.g.base: en,spanish: esThis setup allowed me to ensure that spanish and english files were written to the project's outDir and not the individual
output'soutDiryarn start pull, english and spanish variant files for both.stringsand.stringsdictshould be written to anen.lprojandes.lprojdirectory at the root of the project'soutDirDitto.swiftfile should be written to the root of the project'soutDir. It should have actual swift code in it loliosLocalesshould write to theoutput'soutDiras expected